Change in coreboot[master]: mb/google/nissa/var/nivviks: Update GPIOs to support nirwen - coreboot-gerrit

10 May 2022


      Attention is currently required from: Reka Norman, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64210 )
Change subject: mb/google/nissa/var/nivviks: Update GPIOs to support nirwen
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/gpio.c:
https://review.coreboot.org/c/coreboot/+/64210/comment/d0328832_af06c0a4 
PS10, Line 106: 	if (id == 2) {
I suggest we return NULL and 0 if == 1. Since there is no more nivviks, it switch to nirwen for now on.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I494ed127714069a8f36d16d11ca4e8a1f3d37827
Gerrit-Change-Number: 64210
Gerrit-PatchSet: 10
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Reka Norman rekanorman@google.com
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 May 2022 05:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment