Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/29191 )
Change subject: mb/google/poppy: add the smi_events back ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/29191/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29191/1//COMMIT_MSG@12 PS1, Line 12: always keep in S0.
Can you please mention here that this was broken because of CL:28983?
Done
https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c File src/mainboard/google/poppy/ec.c:
https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27 PS1, Line 27: .smi_events = MAINBOARD_EC_SMI_EVENTS,
Can you please do the same thing for nocturne: https://review.coreboot.org/cgit/coreboot. […]
Done. I don't have nocturne, need someone to help me double check on nocturne.