Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84328?usp=email )
Change subject: soc/intel/xeon_sp/gnr: Enable IRQ routing
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84328/comment/e1fab908_1a826427?usp... :
PS6, Line 13: Signed-off-by: Lu, Pen-ChunX pen-chunx.lu@intel.com
Should Pen-Chun have been the author?
Oops, yes, this is a mistake made in patch porting. Will pay attention the next time.
https://review.coreboot.org/c/coreboot/+/84328/comment/d94b8613_b58a2942?usp... :
PS6, Line 13: Lu, Pen-ChunX pen-chunx.lu@intel.com
Please try to follow the convention and sort it, so that no comma is needed.
Got, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84328?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I095c7a302894437c90d854ce4e30467357eee2ba
Gerrit-Change-Number: 84328
Gerrit-PatchSet: 6
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 08 Nov 2024 13:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org