Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62706 )
Change subject: mb/starlabs/lite: Add Lite Mk IV variant ......................................................................
Patch Set 19:
(4 comments)
File src/mainboard/starlabs/lite/variants/glkr/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62706/comment/cef6cef3_e41d36a1 PS18, Line 6: # Graphics : # TODO: : # register "panel_cfg" = "{ : # .up_delay_ms = 0, // T3 : # .backlight_on_delay_ms = 0, // T7 : # .backlight_off_delay_ms = 0, // T9 : # .down_delay_ms = 0, // T10 : # .cycle_delay_ms = 500, // T12 : # .backlight_pwm_hz = 200, // PWM : # }"
Anything to do?
Make libgfxinit work with GLK(R). Seeing as they all use the Broxton vbt, should be easy.
https://review.coreboot.org/c/coreboot/+/62706/comment/ecdf694b_fe61ba56 PS18, Line 23: register "dptf_enable" = "0"
Can be omitted
Done
https://review.coreboot.org/c/coreboot/+/62706/comment/a2679b94_b317be48 PS18, Line 36: : register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[1]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[2]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[3]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[4]" = "CLKREQ_DISABLED" : register "pcie_rp_clkreq_pin[5]" = "CLKREQ_DISABLED" : : register "pcie_rp_deemphasis_enable[0]" = "1" : register "pcie_rp_deemphasis_enable[1]" = "1" : register "pcie_rp_deemphasis_enable[2]" = "1" : register "pcie_rp_deemphasis_enable[3]" = "1" : register "pcie_rp_deemphasis_enable[4]" = "1" : register "pcie_rp_deemphasis_enable[5]" = "1"
Hmmm, but all PCIe ports are off?
According to FSP debug, still needed.
File src/mainboard/starlabs/lite/variants/glkr/romstage.c:
https://review.coreboot.org/c/coreboot/+/62706/comment/178738fd_473d6dd5 PS18, Line 52: void mainboard_memory_init_params(FSPM_UPD *memupd)
A bunch of the settings in here should be the same for GLK and GLKR. Can be done as a follow-up.
Yup, once APL is done, I want to figure out how to de-dupe the code as around 70% of it is the same for APL, GLK and GLKR.
-
Sean Rhodes (Code Review)