Change in coreboot[master]: mb/system76/lemp9: Add SMBIOS descriptions to root ports

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45110/1

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb
index e648428..514f012 100644
--- a/src/mainboard/system76/lemp9/devicetree.cb
+++ b/src/mainboard/system76/lemp9/devicetree.cb
@@ -171,6 +171,7 @@
    		chip drivers/intel/wifi
    			device pci 00.0 on end
    		end
+			smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230" "SlotDataBusWidth1X"
    	end
    	device pci 1d.0 on	# PCI Express Port 9
    		device pci 00.0 on end # x4 M.2/M 2280
@@ -179,6 +180,7 @@
    		register "PcieClkSrcUsage[4]" = "8"
    		register "PcieClkSrcClkReq[4]" = "4"
    		register "PcieRpSlotImplemented[8]" = "1"
+			smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X"
    	end
    	device pci 1d.1 off end # PCI Express Port 10
    	device pci 1d.2 off end # PCI Express Port 11
@@ -190,6 +192,7 @@
    		register "PcieClkSrcUsage[5]" = "12"
    		register "PcieClkSrcClkReq[5]" = "5"
    		register "PcieRpSlotImplemented[12]" = "1"
+			smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X"
    	end
    	device pci 1d.5 off end # PCI Express Port 14
    	device pci 1d.6 off end # PCI Express Port 15

[Felix Singer (Code Review)]

Hello Jeremy Soller, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45110

to look at the new patch set (#2).

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45110/2

[Felix Singer (Code Review)]

Hello Jeremy Soller, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45110

to look at the new patch set (#3).

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45110/3

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

Patch Set 4: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 174: M.2/E 2230
let's add the label on the board:
M.2/E 2230 (J_WLAN1)

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 183: M.2/M 2280
let's add the label on the board:
M.2/M 2280 (J_SSD2)

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 195: M.2/M 2280
let's add the label on the board:
M.2/M 2280 (J_SSD1)

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Jeremy Soller, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45110

to look at the new patch set (#5).

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 6 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45110/5

[Felix Singer (Code Review)]

Hello build bot (Jenkins), Jeremy Soller, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45110

to look at the new patch set (#6).

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 6 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45110/6

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
File src/mainboard/system76/lemp9/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 174: M.2/E 2230
> let's add the label on the board: […]

Done

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 183: M.2/M 2280
> let's add the label on the board: […]

Done

https://review.coreboot.org/c/coreboot/+/45110/4/src/mainboard/system76/lemp... 
PS4, Line 195: M.2/M 2280
> let's add the label on the board: […]

Done

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

Patch Set 6: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

mb/system76/lemp9: Add SMBIOS descriptions to root ports

Change-Id: Ie663d424edbbeeb8f5691b00f3977f7501e9ab45
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45110
Tested-by: build bot (Jenkins) 
Reviewed-by: Michael Niewöhner
---
M src/mainboard/system76/lemp9/devicetree.cb
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb
index 0cbd5d2..31f411d 100644
--- a/src/mainboard/system76/lemp9/devicetree.cb
+++ b/src/mainboard/system76/lemp9/devicetree.cb
@@ -175,7 +175,7 @@
    	end
    	device pci 1c.6 off end # PCI Express Port 7
    	device pci 1c.7 on	# PCI Express Port 8
-			device pci 00.0 on end # x1 M.2/E 2230 (WLAN)
+			device pci 00.0 on end # x1 M.2/E 2230 (J_WLAN1)
    		register "PcieRpEnable[7]" = "1"
    		register "PcieRpLtrEnable[7]" = "1"
    		register "PcieClkSrcUsage[2]" = "7"
@@ -184,25 +184,28 @@
    		chip drivers/intel/wifi
    			device pci 00.0 on end
    		end
+			smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther" "M.2/E 2230 (J_WLAN1)" "SlotDataBusWidth1X"
    	end
    	device pci 1d.0 on	# PCI Express Port 9
-			device pci 00.0 on end # x4 M.2/M 2280 (Slot 2)
+			device pci 00.0 on end # x4 M.2/M 2280 (J_SSD2)
    		register "PcieRpEnable[8]" = "1"
    		register "PcieRpLtrEnable[8]" = "1"
    		register "PcieClkSrcUsage[4]" = "8"
    		register "PcieClkSrcClkReq[4]" = "4"
    		register "PcieRpSlotImplemented[8]" = "1"
+			smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280 (J_SSD2)" "SlotDataBusWidth4X"
    	end
    	device pci 1d.1 off end # PCI Express Port 10
    	device pci 1d.2 off end # PCI Express Port 11
    	device pci 1d.3 off end # PCI Express Port 12
    	device pci 1d.4 on	# PCI Express Port 13
-			device pci 00.0 on end # x4 M.2/M 2280 (Slot 1)
+			device pci 00.0 on end # x4 M.2/M 2280 (J_SSD1)
    		register "PcieRpEnable[12]" = "1"
    		register "PcieRpLtrEnable[12]" = "1"
    		register "PcieClkSrcUsage[5]" = "12"
    		register "PcieClkSrcClkReq[5]" = "5"
    		register "PcieRpSlotImplemented[12]" = "1"
+			smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280 (J_SSD1)" "SlotDataBusWidth4X"
    	end
    	device pci 1d.5 off end # PCI Express Port 14
    	device pci 1d.6 off end # PCI Express Port 15

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45110 )

Change subject: mb/system76/lemp9: Add SMBIOS descriptions to root ports
......................................................................

Patch Set 11:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17989
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17988
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17987
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17986
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17985
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17992
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17991
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17990

Please note: This test is under development and might not be accurate at all!