Attention is currently required from: Julius Werner, Yu-Ping Wu. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: Fix bugs introduced with CB:59195 ......................................................................
Patch Set 6:
(1 comment)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/3f892bcc_ec84bc92 PS5, Line 30: uint64_t *
Is said "this cast is unnecessary". I did not say "please change this to a uint64_t* cast". […]
hi julius, As you suggested, if assign te->blob_address without type casting i am getting below error:
src/soc/qualcomm/common/qclib.c: In function 'write_mem_chip_information': src/soc/qualcomm/common/qclib.c:30:31: error: assignment to 'void *' from 'uint64_t' {aka 'long long unsigned int'} makes pointer from integer without a cast [-Werror=int-conversion] 30 | mem_chip_addr = te->blob_address;
as per the above error i have mentioned type casting with uint64_t.