Change in coreboot[master]: trogdor : invoke new watchdog function before qclib runs

[Ravi kumar (Code Review)]

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor : invoke new watchdog function before qclib runs
......................................................................

trogdor : invoke new watchdog function before qclib runs

Signed-off-by: Ravi Kumar Bokka 
Change-Id: Ia76323c749a9ba71cc752a91c968aeacc11e0093
---
M src/mainboard/google/trogdor/romstage.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/45212/1

diff --git a/src/mainboard/google/trogdor/romstage.c b/src/mainboard/google/trogdor/romstage.c
index 562e329..8b6f1de 100644
--- a/src/mainboard/google/trogdor/romstage.c
+++ b/src/mainboard/google/trogdor/romstage.c
@@ -3,6 +3,7 @@
 #include <arch/stages.h>
 #include <soc/usb.h>
 #include <soc/qclib_common.h>
+#include <soc/watchdog.h>

static void prepare_usb(void)
 {
@@ -17,6 +18,8 @@
 {
    prepare_usb();

+	check_wdog();
+
    /* QCLib: DDR init & train */
    qclib_load_and_run();
 }

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor : invoke new watchdog function before qclib runs
......................................................................

Patch Set 3: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor : invoke new watchdog function before qclib runs
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45212/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45212/4//COMMIT_MSG@7 
PS4, Line 7: trogdor :
Please remove the space before the colon.

Change in coreboot[master]: trogdor: invoke new watchdog function before qclib runs

[Ravi kumar (Code Review)]

Hello build bot (Jenkins), mturney mturney, Julius Werner, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45212

to look at the new patch set (#5).

Change subject: trogdor: invoke new watchdog function before qclib runs
......................................................................

trogdor: invoke new watchdog function before qclib runs

Signed-off-by: Ravi Kumar Bokka 
Change-Id: Ia76323c749a9ba71cc752a91c968aeacc11e0093
---
M src/mainboard/google/trogdor/romstage.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/45212/5

Change in coreboot[master]: trogdor: invoke new watchdog function before qclib runs

[Ravi Kumar Bokka (Code Review)]

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor: invoke new watchdog function before qclib runs
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45212/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45212/4//COMMIT_MSG@7 
PS4, Line 7: trogdor :
> Please remove the space before the colon.

Done

Change in coreboot[master]: trogdor: invoke new watchdog function before qclib runs

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor: invoke new watchdog function before qclib runs
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: trogdor: invoke new watchdog function before qclib runs

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor: invoke new watchdog function before qclib runs
......................................................................

trogdor: invoke new watchdog function before qclib runs

Signed-off-by: Ravi Kumar Bokka 
Change-Id: Ia76323c749a9ba71cc752a91c968aeacc11e0093
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45212
Reviewed-by: Julius Werner 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/trogdor/romstage.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/romstage.c b/src/mainboard/google/trogdor/romstage.c
index 562e329..8b6f1de 100644
--- a/src/mainboard/google/trogdor/romstage.c
+++ b/src/mainboard/google/trogdor/romstage.c
@@ -3,6 +3,7 @@
 #include <arch/stages.h>
 #include <soc/usb.h>
 #include <soc/qclib_common.h>
+#include <soc/watchdog.h>

static void prepare_usb(void)
 {
@@ -17,6 +18,8 @@
 {
    prepare_usb();

+	check_wdog();
+
    /* QCLib: DDR init & train */
    qclib_load_and_run();
 }

Change in coreboot[master]: trogdor: invoke new watchdog function before qclib runs

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45212 )

Change subject: trogdor: invoke new watchdog function before qclib runs
......................................................................

Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19488
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19487
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19486
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19485
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19484
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19492
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19491
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19490
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19489

Please note: This test is under development and might not be accurate at all!