Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40278 )
Change subject: mb/purism/librem_whl: Add new board Librem Mini (WHL-U) ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40278/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40278/4/src/mainboard/purism/librem... PS4, Line 166: Enable
I don't think so
Done
https://review.coreboot.org/c/coreboot/+/40278/4/src/mainboard/purism/librem... PS4, Line 167: register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0"
Those default to zero already and make no sense with "deep_sx_config" = "0"
Done
-
Matt DeVillier (Code Review)