Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Julius Werner, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
Rishika Raj has posted comments on this change by Rishika Raj. ( https://review.coreboot.org/c/coreboot/+/83540?usp=email )
Change subject: soc/intel/meteorlake: Increase CAR STACK_SIZE by 31KB to meet coreboot requirements ......................................................................
Patch Set 5:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83540/comment/f4d01d0e_9740b325?usp... : PS1, Line 2: rishikraj
Please use Rishika Raj: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/c3ed380c_fce3fbe2?usp... : PS1, Line 7: soc/intel/meteorlake: Change DCACHE_BSP_STACK_SIZE
Maybe even: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/7b4fa1f4_1c10050d?usp... : PS1, Line 8:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/aa005029_8d9638cf?usp... : PS1, Line 9: as required by the coreboot
Please elaborate.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/ec206abc_d6012b7a?usp... : PS1, Line 9: 1KB to 512KB + 32KB
Use just one space where there are two?
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/e5ca5ac0_a2f3974a?usp... : PS1, Line 11: Bug
BUG
Acknowledged
https://review.coreboot.org/c/coreboot/+/83540/comment/632e6e1c_bf44561c?usp... : PS1, Line 12: Test
TEST
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/83540/comment/38bf871a_c9f649d8?usp... : PS2, Line 7: Incrase
typo?
Acknowledged