Attention is currently required from: Raul Rangel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56051 )
Change subject: lib/prog_loaders: Add payload_preload ......................................................................
Patch Set 9:
(2 comments)
File src/lib/prog_loaders.c:
https://review.coreboot.org/c/coreboot/+/56051/comment/bc282502_3d0de06f PS8, Line 160: return;
I don't think we need a dead_code here. […]
Hmm... if you want callers to just always call this and have it figure itself out, maybe do the thing where there's a static inline stub in the header file when the option is disabled instead? I think that's a more common pattern for this in coreboot.
https://review.coreboot.org/c/coreboot/+/56051/comment/bedca5cc_d0c7ae1f PS8, Line 162: if (prog_locate_hook(payload))
Are you saying remove it from payload_preload and change payload_load to the following? […]
Yeah, I would say write it the way you did there. It's really more about blocking program execution than program loading. If you do it up here it might get confused from running way earlier than intended.
-
Julius Werner (Code Review)