Attention is currently required from: Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Lance Zhao, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tarun, Tim Wawrzynczak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78164?usp=email )
Change subject: acpi: Configure slp-s0 residency counter frequency in LPIT table
......................................................................
Patch Set 17:
(2 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78164/comment/0e113f6a_214b01f3 :
PS17, Line 457: ACPI_SOC_INTEL_SLP_S0_FREQ_HZ
take a look into https://qa.coreboot. […]
Captured in case the build goes away before this is looked into:
```
make[2]: *** [Makefile:405: /cb-build/coreboot-gerrit.0/emu_clang_allthreads/EMULATION_QEMU_X86_Q35/romstage/device/pci_ops.o] Error 1
In file included from src/drivers/pc80/tpm/tis.c:17:
src/include/acpi/acpi.h:457:5: error: 'CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ' is not defined, evaluates to 0 [-Werror,-Wundef]
#if CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ != 0
```
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78164/comment/333a24d3_5cb84f80 :
PS13, Line 457: #if CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ != 0
```
#if defined CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ && CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ != 0
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78164?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I401dd4a09a67d81a9ea3a56cd22f1a681e2a9349
Gerrit-Change-Number: 78164
Gerrit-PatchSet: 17
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 18:52:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment