Attention is currently required from: Felix Held, Karthik Ramasubramanian, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78191?usp=email )
Change subject: util/amdfwtool: Check for pkg-config presence
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/78191/comment/003c8e94_0726e318 :
PS1, Line 26: shell
Done
Hrmm, I think it was failing because CFLAGS was lazily evaluated.
Changing flags to use the `:=` operator should make the `$(shell) evaluate eagerly so you can catch the error when it happens.
i.e.,
```
CFLAGS:=-O2 -Wall -Wextra -Wshadow ${WERROR}
```
See https://www.gnu.org/software/make/manual/html_node/Simple-Assignment.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d604145c919e7f71680d1e095dc68cb21868319
Gerrit-Change-Number: 78191
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Oct 2023 23:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment