New patch to review for coreboot: 42fb287 exynos5250: Don't disable and re-enable the MMU when uncaching the framebuffer.

[Gabe Black]

Gabe Black ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3654

-gerrit

commit 42fb28706ecbe28ae32bffbed2699e6d28c17852
Author: Gabe Black 
Date:   Sat May 18 22:57:34 2013 -0700

exynos5250: Don't disable and re-enable the MMU when uncaching the framebuffer.

At one time it seemed to be necessary to disable and then re-enable the MMU
    when setting the framebuffer to be uncache-able due to bugs in the MMU
    management code. Since those bugs have been fixed, this is no longer
    necessary.

Change-Id: I5f7b9bd14dc9929efe1834ec9a258d388b8c94e9
    Signed-off-by: Gabe Black 
---
 src/cpu/samsung/exynos5250/cpu.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/cpu/samsung/exynos5250/cpu.c b/src/cpu/samsung/exynos5250/cpu.c
index 3ab57c9..d2a6df7 100644
--- a/src/cpu/samsung/exynos5250/cpu.c
+++ b/src/cpu/samsung/exynos5250/cpu.c
@@ -105,15 +105,11 @@ static void exynos_displayport_init(device_t dev)
     * Note: We may want to do something clever to ensure the framebuffer
     * region is aligned such that we don't change dcache policy for other
     * stuff inadvertantly.
-	 *
-	 * FIXME: Is disabling/re-enabling the MMU entirely necessary?
     */
    uint32_t lower = ALIGN_DOWN(lcdbase, MiB);
    uint32_t upper = ALIGN_UP(lcdbase + fb_size, MiB);
    dcache_clean_invalidate_by_mva(lower, upper - lower);
-	dcache_mmu_disable();
    mmu_config_range(lower/MiB, (upper - lower)/MiB, DCACHE_OFF);
-	dcache_mmu_enable();

mmio_resource(dev, 1, lcdbase/KiB, (fb_size + KiB - 1)/KiB);
    printk(BIOS_DEBUG,