DAWEI CHIEN has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
3rdparty/blobs: Update submodule
Uprev the 3rdparty/blobs submodule to the newest HEAD, which contains the SPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/34543 ).
Change-Id: I505ec9fffd9ddd62fffbe9514cbba50625825693 Signed-off-by: Dawei Chien dawei.chien@mediatek.com --- D 3rdparty/blobs A 3rdparty/blobs 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/34734/1
diff --git a/3rdparty/blobs b/3rdparty/blobs deleted file mode 160000 index 9da6d88..0000000 --- a/3rdparty/blobs +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 9da6d88a2b0f553b724e70d80a78d7e78f074f5b diff --git a/3rdparty/blobs b/3rdparty/blobs new file mode 100644 index 0000000..bdbf0f4 --- /dev/null +++ b/3rdparty/blobs @@ -0,0 +1 @@ +Subproject commit I8878a1c8460038686ad97e89ec0d7774621b8f85
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, Huayang Duan, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34734
to look at the new patch set (#2).
Change subject: 3rdparty/blobs: Update submodule ......................................................................
3rdparty/blobs: Update submodule
Uprev the 3rdparty/blobs submodule to the newest HEAD, which contains the SPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/34543 ).
Change-Id: I505ec9fffd9ddd62fffbe9514cbba50625825693 Signed-off-by: Dawei Chien dawei.chien@mediatek.com --- D 3rdparty/blobs A 3rdparty/blobs 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/34734/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG@7 PS2, Line 7: 3rdparty/blobs: Update submodule Specify with submodule is updated. (e.g Update SPM binary for MT8183)
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG@9 PS2, Line 9: Uprev the 3rdparty/blobs submodule to the newest HEAD, which 'Update'?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2: Code-Review-1
No rule to make target '3rdparty/blobs/soc/amd/stoneyridge/xhci.bin
Sounds like you've set a wrong hash and reverted some files?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2: -Code-Review
DAWEI CHIEN has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2: Code-Review-1
No rule to make target '3rdparty/blobs/soc/amd/stoneyridge/xhci.bin
Sounds like you've set a wrong hash and reverted some files?
Actually, this patch is not made by submodule command, I would try to add new one by submodule command.
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG@7 PS2, Line 7: 3rdparty/blobs: Update submodule
Specify with submodule is updated. (e. […]
Done
https://review.coreboot.org/c/coreboot/+/34734/2//COMMIT_MSG@9 PS2, Line 9: Uprev the 3rdparty/blobs submodule to the newest HEAD, which
'Update'?
Done
Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, Huayang Duan, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34734
to look at the new patch set (#3).
Change subject: 3rdparty/blobs: Update submodule for MT8183 ......................................................................
3rdparty/blobs: Update submodule for MT8183
Update the 3rdparty/blobs submodule to the newest HEAD, which contains the SPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/34543 ).
Change-Id: I505ec9fffd9ddd62fffbe9514cbba50625825693 Signed-off-by: Dawei Chien dawei.chien@mediatek.com --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/34734/3
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule for MT8183 ......................................................................
Patch Set 3: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule for MT8183 ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34734 )
Change subject: 3rdparty/blobs: Update submodule for MT8183 ......................................................................
3rdparty/blobs: Update submodule for MT8183
Update the 3rdparty/blobs submodule to the newest HEAD, which contains the SPM binary for MT8183 platforms ( https://review.coreboot.org/c/blobs/+/34543 ).
Change-Id: I505ec9fffd9ddd62fffbe9514cbba50625825693 Signed-off-by: Dawei Chien dawei.chien@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34734 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved
diff --git a/3rdparty/blobs b/3rdparty/blobs index 9da6d88..62aa0e0 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 9da6d88a2b0f553b724e70d80a78d7e78f074f5b +Subproject commit 62aa0e0c54295bbb7b1a3e5e73f960bafdb59d04
-
DAWEI CHIEN (Code Review) -
Frans Hendriks (Code Review)
-
Hung-Te Lin (Code Review)
-
Martin Roth (Code Review)