Attention is currently required from: Arthur Heymans, Wim Vervoorn. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52128 )
Change subject: mb/faceboot/fbg1701/romstage.c: Set disable_saved_data ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52128/comment/35415455_a5f4c5b6 PS2, Line 9: ASSERTION ERROR
Can you point where the issue occurs?
ASSERTION ERROR: file 'src/security/vboot/common.c', line 23
Do you expect this in commit message?
https://review.coreboot.org/c/coreboot/+/52128/comment/29ac0c27_919bc687 PS2, Line 9: MRC
MRC_CACHE?
RW_MRC_CACHE
https://review.coreboot.org/c/coreboot/+/52128/comment/d2e788da_e632edc0 PS2, Line 11: space
CAR space
Done
https://review.coreboot.org/c/coreboot/+/52128/comment/8dee6a64_6dd6db38 PS2, Line 11: not
not enough
Done
https://review.coreboot.org/c/coreboot/+/52128/comment/aebc819d_2988b3c2 PS2, Line 13: SPI is too small for _vboot2_work buffer.
What does this mean?
Mistake CAR is too small.