Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 79:
Thanks for clarifying, the PCH datasheet doesn't explain 'upper' and 'lower'.
Done
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 104:
Unused pci-e ports are set to off in the newest revision.
Done
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 173:
Yes, I have tried setting has_bdc_detection=1 and bdc_gpio_num=54.
Done
https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/overridetree.cb:
https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x... PS8, Line 17: subsystemid 0x17aa 0x21e8
I am just reproducing the behavior of the vendor firmware which sets them to 17aa:21e8.
Done
-
Bill XIE (Code Review)