Change in ...coreboot[master]: ec/google/wilco: Turn on wake up from lid - coreboot-gerrit

18 Jan 2019


      Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30824 )
Change subject: ec/google/wilco: Turn on wake up from lid
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30824/6/src/ec/google/wilco/commands.h 
File src/ec/google/wilco/commands.h:
https://review.coreboot.org/#/c/30824/6/src/ec/google/wilco/commands.h@278 
PS6, Line 278: EC_ACPI_WAKE_PWRB
...
I don't think this and LID are actually implemented (or can be disabled) and they are force/default  […]
Spec said power button had been force enabled, but lid switch not enabled by default, we checked during power on time.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30824
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13f3469847b0886147b8b624311a1ece796f847b
Gerrit-Change-Number: 30824
Gerrit-PatchSet: 6
Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com
Gerrit-Reviewer: Krzysztof M Sywula krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Jan 2019 07:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment