Attention is currently required from: Arthur Heymans, Varshit Pandya.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76512?usp=email )
Change subject: vendorcode/amd/opensil: Implement console callback
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Any objection to me renaming console.h and console.c to opensil_console.[ch] so that it's not yet another console.h file that we're including?
Then it can be included with #include "opensil_console.h". I'd rather not have the full include path hardcoded if we can avoid it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208eea37ffde64a2311cb9f51e2bcd1ac3dbad4d
Gerrit-Change-Number: 76512
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 27 Sep 2023 21:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment