Change in coreboot[master]: mb/google/zork: Add USB 2.0 strength for Woomax

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

23 Sep 2020 23 Sep '20

9:07 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Add USB 2.0 strength for Woomax ......................................................................

mb/google/zork: Add USB 2.0 strength for Woomax

Add USB 2.0 setting: 1. USB 2.0 TypeC port0 0xf1333e13. 2. USB 2.0 TypeC port3 0xf1333e13.

BUG=None BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/1

diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index de39891..f6eb165 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -22,6 +22,30 @@ register "telemetry_vddcr_soc_offset" = "0"

# End : OPN Performance Configuration + #USB 2.0 strength + register "usb_2_port_tune_params[0]" = "{ + .com_pds_tune = 0x03, + .sq_rx_tune = 0x3, + .tx_fsls_tune = 0x3, + .tx_pre_emp_amp_tune = 0x03, + .tx_pre_emp_pulse_tune = 0x0, + .tx_rise_tune = 0x1, + .rx_vref_tune = 0xf, + .tx_hsxv_tune = 0x3, + .tx_res_tune = 0x01, + }" + + register "usb_2_port_tune_params[3]" = "{ + .com_pds_tune = 0x03, + .sq_rx_tune = 0x3, + .tx_fsls_tune = 0x3, + .tx_pre_emp_amp_tune = 0x03, + .tx_pre_emp_pulse_tune = 0x0, + .tx_rise_tune = 0x1, + .rx_vref_tune = 0xf, + .tx_hsxv_tune = 0x3, + .tx_res_tune = 0x01, + }"

# USB OC pin mapping register "usb_port_overcurrent_pin[2]" = "USB_OC_NONE" # NC

Attachments:

attachment.htm (text/html — 4.4 KB)

Show replies by date

Kane Chen (Code Review)

23 Sep 23 Sep

9:09 a.m.

Kane Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Add USB 2.0 strength for Woomax ......................................................................

mb/google/zork: Add USB 2.0 strength for Woomax

Add USB 2.0 setting: 1. USB 2.0 TypeC port0 0xf1333e13. 2. USB 2.0 TypeC port3 0xf1333e13.

BUG=b:169207729 BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/2

build bot (Jenkins) (Code Review)

9:17 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Add USB 2.0 strength for Woomax ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45641/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45641/1/src/mainboard/google/zork/v... PS1, Line 25: #USB 2.0 strength trailing whitespace

Kane Chen (Code Review)

24 Sep 24 Sep

4:32 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45641

to look at the new patch set (#3).

Change subject: mb/google/zork: Add USB 2.0 strength for Woomax ......................................................................

mb/google/zork: Add USB 2.0 strength for Woomax

Add USB 2.0 setting: 1. USB 2.0 TypeC port0 0xf1333e13. 2. USB 2.0 TypeC port3 0xf1333e13.

BUG=None BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/3

Kane Chen (Code Review)

4:59 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45641

to look at the new patch set (#4).

Change subject: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram ......................................................................

mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

Add USB 2.0 setting: 1. USB 2.0 TypeC port0: .com_pds_tune = 0x03, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03, .tx_pre_emp_pulse_tune = 0x0, .tx_rise_tune = 0x1, .rx_vref_tune = 0xf, .tx_hsxv_tune = 0x3, .tx_res_tune = 0x01,

2. USB 2.0 TypeC port3: .com_pds_tune = 0x03, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03, .tx_pre_emp_pulse_tune = 0x0, .tx_rise_tune = 0x1, .rx_vref_tune = 0xf, .tx_hsxv_tune = 0x3, .tx_res_tune = 0x01,

BUG=None BRANCH=None TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/4

Aaron Durbin (Code Review)

5:20 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@7 PS4, Line 7: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram You should mention this is for woomax in the subject.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 24 Sep 2020 14:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Eric Peers (Code Review)

7:33 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@32 PS4, Line 32: BUG=None BUG=b:169207729

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@33 PS4, Line 33: BRANCH=None Need a BRANCH=zork to ensure it gets cherry-picked to the firmware branch when landing at chromium

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 24 Sep 2020 16:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

25 Sep 25 Sep

4:51 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45641

to look at the new patch set (#5).

Change subject: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram ......................................................................

mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

BUG=b:169207729 BRANCH=zork TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

4:54 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45641

to look at the new patch set (#6).

Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax ......................................................................

mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Modify USB 2.0 PHY parameters for improve usb eye diagram. 1. USB 2.0 TypeC port0: .com_pds_tune = 0x03, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03, .tx_pre_emp_pulse_tune = 0x0, .tx_rise_tune = 0x1, .rx_vref_tune = 0xf, .tx_hsxv_tune = 0x3, .tx_res_tune = 0x01,

BUG=b:169207729 BRANCH=zork TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/45641/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

4:55 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax ......................................................................

Patch Set 6: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@7 PS4, Line 7: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram

...

You should mention this is for woomax in the subject.

Done

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@32 PS4, Line 32: BUG=None

...

BUG=b:169207729

Done

https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@33 PS4, Line 33: BRANCH=None

...

Need a BRANCH=zork to ensure it gets cherry-picked to the firmware branch when landing at chromium

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 01:55:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Peers epeers@google.com Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Aaron Durbin (Code Review)

6:02 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Fri, 25 Sep 2020 15:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

6:02 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax ......................................................................

mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

BUG=b:169207729 BRANCH=zork TEST=emerge-zork coreboot chromeos-bootimage

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45641 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 24 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index de39891..d1c5507 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -22,6 +22,30 @@ register "telemetry_vddcr_soc_offset" = "0"

# USB OC pin mapping register "usb_port_overcurrent_pin[2]" = "USB_OC_NONE" # NC

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: merged

Rob Barnes (Code Review)

16 Oct 16 Oct

1:54 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax

Rob Barnes has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/45641 )

Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax ......................................................................

-- To view, visit https://review.coreboot.org/c/coreboot/+/45641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550 Gerrit-Change-Number: 45641 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: revert

1556

days inactive

1578

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
build bot (Jenkins) (Code Review)
Eric Peers (Code Review)
Kane Chen (Code Review)
Rob Barnes (Code Review)