Change in coreboot[master]: [WIP]soc/intel/common: Add common code to report platform information
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25810 )
Change subject: [WIP]soc/intel/common: Add common code to report platform information ......................................................................
Patch Set 5:
(28 comments)
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootbl... File src/soc/intel/common/basecode/bootblock/report_platform.c:
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootbl... PS5, Line 32: __weak const struct cpu_info* soc_get_cpu_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootbl... PS5, Line 38: __weak const struct mch_info* soc_get_mch_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootbl... PS5, Line 44: __weak const struct pch_info* soc_get_pch_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootbl... PS5, Line 50: __weak const struct igd_info* soc_get_igd_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 19: struct cpu_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 20: u32 cpuid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 20: u32 cpuid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 21: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 21: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 24: struct mch_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 25: u16 mchid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 25: u16 mchid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 26: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 26: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 29: struct pch_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 30: u16 lpcid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 30: u16 lpcid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 31: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 31: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 34: struct igd_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 35: u16 igdid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 35: u16 igdid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 36: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 36: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 40: const struct cpu_info* soc_get_cpu_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 43: const struct mch_info* soc_get_mch_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 46: const struct pch_info* soc_get_pch_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/includ... PS5, Line 49: const struct igd_info* soc_get_igd_id_table(void); "foo* bar" should be "foo *bar"
-
build bot (Jenkins) (Code Review)