Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50626 )
Change subject: soc/amd/picasso: introduce and use chipset device tree
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/picasso/chipset.cb:
https://review.coreboot.org/c/coreboot/+/50626/comment/00e4499f_229cd556
PS6, Line 18: on
I think I would leave these off by default.
i strongly disagree on this, since this device needs to be enabled in order for internal_bridge_a and internal_bridge_b to work. when function 0 of a pcie device is disabled, all other functions are assumed to be disabled too. same argument for device pci 01.0 above.
checked with the cezanne chipset devicetree and device pci 08.0 is also enabled there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b7c3fd32579a23539594672593a243172c161c7
Gerrit-Change-Number: 50626
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 16:13:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment