Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48151 )
Change subject: edist-test: Fix _Static_assert missing message string ......................................................................
edist-test: Fix _Static_assert missing message string
Older GCCs don't support _Static_assert without a message string as the second argument. AFAICT _Static_assert with two arguments is in C11 but omitting the message argument is an extension.
The tests appear to be built with the system gcc rather than our crossgcc so that's probably why this was not cought by CI.
Change-Id: I41fd0ffc42ded8b6d145c3ec30cc7407a78b9a43 Signed-off-by: Daniel Gröber dxld@darkboxed.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/48151 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M tests/include/lib/edid-test.h 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/tests/include/lib/edid-test.h b/tests/include/lib/edid-test.h index 073905d..8327748 100644 --- a/tests/include/lib/edid-test.h +++ b/tests/include/lib/edid-test.h @@ -43,7 +43,8 @@ uint8_t checksum; } __packed;
-_Static_assert(sizeof(struct edid_raw) == 128); +_Static_assert(sizeof(struct edid_raw) == 128, + "assert failed: edid_raw size mismatch");
#define EDID_HEADER_RAW { 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00 } #define EDID_HEADER_INVALID_RAW { 0, 0, 0, 0, 0, 0, 0, 0 }