Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55136 )
Change subject: psp_verstage: initialize i2c in soc_init
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/picasso/psp_verstage/chipset.c:
https://review.coreboot.org/c/coreboot/+/55136/comment/e5123b4d_8ca0c039
PS2, Line 31: espi_setup();
Actually, zork is also doing the exact same work i.e.
```
» enable_aoac_devices();
» setup_i2c();
```
in verstage_mainboard_init(). Do you think it makes sense to simply add this to psp_verstage/chipset.c?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f7b73be67a692ea7de31ae53bd111d0e4b6998c
Gerrit-Change-Number: 55136
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Jun 2021 03:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment