Attention is currently required from: Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78228?usp=email )
Change subject: sb/intel/bd82x6x: Improve SLCAP
......................................................................
Patch Set 3:
(1 comment)
File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/78228/comment/7f89e25a_5172637d :
PS2, Line 152: reg32 |= (slot_number++ << 19);
Yes, I left a request on another commit to leave a comment that we don't follow the specs when we un […]
It starts now counting at 1.
I've added a hack that works when GENERATE_SMBIOS_TABLES is true to detect if it's a slot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78228?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03aeb0a1ff0041901acc20fe700d3f7995d22366
Gerrit-Change-Number: 78228
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 08 Oct 2023 11:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment