Change in coreboot[master]: [Try] mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

List overview All Threads
Download

newer

older

Change in coreboot[master]: [Try]...

Change in coreboot[master]: [try]...

HAOUAS Elyes (Code Review)

15 Dec 2019 15 Dec '19

2:26 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [Try] mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

[Try] mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Untested.

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 3 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/1

diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig index 3b6cb5c..820d43e 100644 --- a/src/mainboard/amd/parmer/Kconfig +++ b/src/mainboard/amd/parmer/Kconfig @@ -17,7 +17,6 @@

config BOARD_SPECIFIC_OPTIONS def_bool y - select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY15_TN select NORTHBRIDGE_AMD_AGESA_FAMILY15_TN select SOUTHBRIDGE_AMD_AGESA_HUDSON diff --git a/src/mainboard/amd/parmer/Makefile.inc b/src/mainboard/amd/parmer/Makefile.inc index f8895fa..4dde2cf 100644 --- a/src/mainboard/amd/parmer/Makefile.inc +++ b/src/mainboard/amd/parmer/Makefile.inc @@ -13,6 +13,8 @@ # GNU General Public License for more details. #

+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/parmer/romstage.c b/src/mainboard/amd/parmer/bootblock.c similarity index 83% rename from src/mainboard/amd/parmer/romstage.c rename to src/mainboard/amd/parmer/bootblock.c index 6366c4e..d4bb8c2 100644 --- a/src/mainboard/amd/parmer/romstage.c +++ b/src/mainboard/amd/parmer/bootblock.c @@ -13,11 +13,10 @@ * GNU General Public License for more details. */

+#include <bootblock_common.h> #include <device/pci_ops.h> -#include <northbridge/amd/agesa/state_machine.h> -#include <southbridge/amd/agesa/hudson/hudson.h>

-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { pci_devfn_t dev = PCI_DEV(0, 0x14, 3);

Attachments:

attachment.htm (text/html — 4.2 KB)

Show replies by date

HAOUAS Elyes (Code Review)

16 Dec 16 Dec

5:34 a.m.

New subject: Change in coreboot[master]: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37744

to look at the new patch set (#2).

Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Untested.

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

17 Dec 17 Dec

7:47 p.m.

New subject: Change in coreboot[master]: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37744

to look at the new patch set (#3).

Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 2 files changed, 4 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

21 Dec 21 Dec

8:29 a.m.

New subject: Change in coreboot[master]: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Mike Banon has uploaded a new patch set (#4) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

30 Dec 30 Dec

3:52 a.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37744

to look at the new patch set (#9).

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

[TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

31 Dec 31 Dec

1:58 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Mike Banon has uploaded a new patch set (#11) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

[TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37744/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

1:59 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

Patch Set 11:

Last code removal is like at CB:37829 .

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 31 Dec 2019 12:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7 Jan 7 Jan

5:34 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

Abandoned

not tested

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

HAOUAS Elyes (Code Review)

12 Jan 12 Jan

6:18 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: restore

HAOUAS Elyes (Code Review)

4 Feb 4 Feb

9:30 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37744 )

Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................

Abandoned

no one will test ... so drop unmaintained board

-- To view, visit https://review.coreboot.org/c/coreboot/+/37744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id088304ddbd7aa05399f3172c2bdb6360d41f834 Gerrit-Change-Number: 37744 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1754

days inactive

1805

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Mike Banon (Code Review)