[S] Change in coreboot[master]: cpu/intel/car/romstage: Clear graphics before exiting romstage - coreboot-gerrit

18 Dec 2022


      Attention is currently required from: Bora Guvendik, Zhixing Ma, Hannah Williams, Cliff Huang, Nico Huber, Michał Żygowski, Subrata Banik, Jérémy Compostella, Paul Menzel, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70302 )
Change subject: cpu/intel/car/romstage: Clear graphics before exiting romstage
......................................................................
Patch Set 22:
(1 comment)
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/70302/comment/ced448a3_8a5aef43 
PS22, Line 72: #if CONFIG(SOC_INTEL_COMMON_BLOCK_GRAPHICS)
Does this need to happen in CPP rather than C code?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70302
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31b6470478177938f988afe11febaadd165c4b52
Gerrit-Change-Number: 70302
Gerrit-PatchSet: 22
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Zhixing Ma zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Zhixing Ma zhixing.ma@intel.com
Gerrit-Attention: Hannah Williams hannah.williams@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 18 Dec 2022 10:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment