Change in coreboot[master]: mb/google/octopus: Set default value of ModPhyIfValue parameter

[shkim (Code Review)]

Hello SH Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/44436

to review the following change.

Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................

mb/google/octopus: Set default value of ModPhyIfValue parameter

Set default value of ModPhyIfValue parameter in FSPS_UPD.
Without this setting, it will be set to '0' and system may not detect
USB 3.0 device.

BUG=b:163382089
BRANCH=firmware-octopus-11297.B
TEST=Built

Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4
Signed-off-by: Seunghwan Kim 
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44436/1

diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
index 80e4873..ea5325a 100644
--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
@@ -285,4 +285,8 @@
    # PWROKDELAY[2:0]: 000=2.5ms, 001=5.0ms, 010=10ms, 011=15ms, 100=20ms,
    #                  101=50ms, 110=75ms, 111=100ms (default)
    register "PmicPmcIpcCtrl" = "0x5e4302f8"
+
+	# FSP UPD to modify the Integrated Filter (IF) value
+	# 0x12(Default) for Windows, 0x16 for Chrome
+	register "ModPhyIfValue" = "0x16"
 end

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44436 )

Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44436 )

Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44436 )

Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................

Patch Set 1: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44436 )

Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................

mb/google/octopus: Set default value of ModPhyIfValue parameter

Set default value of ModPhyIfValue parameter in FSPS_UPD.
Without this setting, it will be set to '0' and system may not detect
USB 3.0 device.

BUG=b:163382089
BRANCH=firmware-octopus-11297.B
TEST=Built

Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4
Signed-off-by: Seunghwan Kim 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44436
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
index 80e4873..ea5325a 100644
--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
@@ -285,4 +285,8 @@
    # PWROKDELAY[2:0]: 000=2.5ms, 001=5.0ms, 010=10ms, 011=15ms, 100=20ms,
    #                  101=50ms, 110=75ms, 111=100ms (default)
    register "PmicPmcIpcCtrl" = "0x5e4302f8"
+
+	# FSP UPD to modify the Integrated Filter (IF) value
+	# 0x12(Default) for Windows, 0x16 for Chrome
+	register "ModPhyIfValue" = "0x16"
 end