Attention is currently required from: Philipp Hug, Matt DeVillier, Angel Pons, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )
Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................
Patch Set 10:
(2 comments)
File src/soc/qualcomm/qcs405/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/cf0427a7_ab0e911f
PS10, Line 7: (uintptr_t)
nit: Is this cast really requires here? Also in other files?
File src/soc/samsung/exynos5250/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/038feee8_8be07476
PS10, Line 8: (uintptr_t)
nit: same as in case of previous literal casts. Also applies to other returns like this one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6
Gerrit-Change-Number: 69078
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Nov 2022 11:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment