Change in ...coreboot[master]: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU - coreboot-gerrit

24 Jan 2019


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29668 )
Change subject: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/29668/7/src/northbridge/intel/sandybridge/ac... 
File src/northbridge/intel/sandybridge/acpi.c:
https://review.coreboot.org/#/c/29668/7/src/northbridge/intel/sandybridge/ac... 
PS7, Line 101: 		current += acpi_create_igfx_rmrr(current);
what happens on error if acpi_create_igfx_rmrr returns 0 ?
Does acpi_dmar_rmrr_fixup handle that properly ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29668
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I391d0a5f1ea14bc90fbacabce41dddfa12b5bb0d
Gerrit-Change-Number: 29668
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 24 Jan 2019 08:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment