Attention is currently required from: Idwer Vollering, Stefan Reinauer, Julius Werner, Arthur Heymans, Krystian Hebel, Timothy Pearson.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55039 )
Change subject: util/cbfstool/flashmap/fmap.c: fix fmaptool endianness bugs on BE
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
Added -D_DEFAULT_SOURCE to util/ifdtool/Makefile.inc instead of defining it in code.
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/55039/comment/58ea3cd6_4b42df56
PS7, Line 7: * It is required for endianness converting functions.
Then why not add it to the ifdtool Makefile? I think that would be more appropriate than this.
Moved it there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia88c0625cefa1e594ac1849271a71c3aacc8ce78
Gerrit-Change-Number: 55039
Gerrit-PatchSet: 9
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Comment-Date: Fri, 05 Nov 2021 16:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment