Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/62628
to review the following change.
Change subject: mb/google/brya: change loglevel prefix ......................................................................
mb/google/brya: change loglevel prefix
Change loglevel from "BIOS_ERR" to "BIOS_INFO/BIOS_DEBUG/BIOS_SPEW"
BUG=b:222038287 TEST=emerge-bry coreboot
Change-Id: I5de038abba235ea5df866c194118143fcf3f7188 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/device/device.c M src/drivers/intel/usb4/retimer/retimer.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/ec_smbios.c M src/mainboard/google/brya/variants/baseboard/brask/ramstage.c M src/soc/intel/alderlake/retimer.c M src/soc/intel/common/block/cse/cse_eop.c 7 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/62628/1
diff --git a/src/device/device.c b/src/device/device.c index 8337d55..9c153ed 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -167,7 +167,7 @@
if (!curdev->ops || !curdev->ops->read_resources) { if (curdev->path.type != DEVICE_PATH_APIC) - printk(BIOS_ERR, "%s missing %s\n", + printk(BIOS_SPEW, "%s missing %s\n", dev_path(curdev), __func__); continue; } @@ -277,7 +277,7 @@ continue;
if (!curdev->ops || !curdev->ops->set_resources) { - printk(BIOS_ERR, "%s missing set_resources\n", + printk(BIOS_SPEW, "%s missing set_resources\n", dev_path(curdev)); continue; } diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 0c027eb..58ef2a8 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -358,7 +358,7 @@ for (dfp_port = 0; dfp_port < DFP_NUM_MAX; dfp_port++) {
if (!config->dfp[dfp_port].power_gpio.pin_count) { - printk(BIOS_ERR, "%s: No DFP%1d power GPIO for %s\n", + printk(BIOS_INFO, "%s: No DFP%1d power GPIO for %s\n", __func__, dfp_port, dev_path(dev)); continue; } diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index a82ea5d..52469d4 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -239,7 +239,7 @@ /* Check result */ cec_command->cmd_code = read_byte(EC_LPC_ADDR_HOST_DATA); if (cec_command->cmd_code) { - printk(BIOS_ERR, "EC returned error result code %d\n", + printk(BIOS_INFO, "EC returned error result code %d\n", cec_command->cmd_code); return -i; } diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index 1ee7283..d62a0a0 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -29,7 +29,7 @@
if (google_chromeec_cbi_get_oem_name(&oem_name[0], ARRAY_SIZE(oem_name)) < 0) { - printk(BIOS_ERR, "Couldn't obtain OEM name from CBI\n"); + printk(BIOS_INFO, "Couldn't obtain OEM name from CBI\n"); manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER; } else { manuf = &oem_name[0]; diff --git a/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c b/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c index 9628b44..f80fa6c 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c +++ b/src/mainboard/google/brya/variants/baseboard/brask/ramstage.c @@ -29,7 +29,7 @@ }
if (i == ARRAY_SIZE(cpuid_to_adl)) { - printk(BIOS_ERR, "Cannot find correct intel sku index.\n"); + printk(BIOS_DEBUG, "Cannot find correct intel sku index.\n"); return false; }
@@ -41,7 +41,7 @@ }
if (i == num_entries) { - printk(BIOS_ERR, "Cannot find correct brask sku index.\n"); + printk(BIOS_DEBUG, "Cannot find correct brask sku index.\n"); return false; }
diff --git a/src/soc/intel/alderlake/retimer.c b/src/soc/intel/alderlake/retimer.c index 09bf112..3fd9c2d 100644 --- a/src/soc/intel/alderlake/retimer.c +++ b/src/soc/intel/alderlake/retimer.c @@ -18,7 +18,7 @@
for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) { if (i == typec_port) { - printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", typec_port, + printk(BIOS_INFO, "USB Type-C %d mapped to EC port %d\n", typec_port, ec_port); return ec_port; } diff --git a/src/soc/intel/common/block/cse/cse_eop.c b/src/soc/intel/common/block/cse/cse_eop.c index 3a08a73..4cf7110 100644 --- a/src/soc/intel/common/block/cse/cse_eop.c +++ b/src/soc/intel/common/block/cse/cse_eop.c @@ -172,7 +172,7 @@ static bool eop_sent = false;
if (eop_sent) { - printk(BIOS_ERR, "EOP already sent\n"); + printk(BIOS_INFO, "EOP already sent\n"); return; }