[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold - coreboot-gerrit

1 Feb 2023


      Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 )
Change subject: soc/amd/mendocino: Force resets to be cold
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/mendocino/fch.c:
https://review.coreboot.org/c/coreboot/+/72486/comment/b2217d80_015dfbf4 
PS3, Line 131: 	pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | TOGGLE_ALL_PWR_GOOD);
...
...
fch_init_resets() is there so that when Linux does a reset, it's a cold reset. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb4cc6eb6e6de9616d00d0191ccf3c0ac55278
Gerrit-Change-Number: 72486
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-CC: John Su john_su@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Feb 2023 17:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment