Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75835?usp=email )
Change subject: lib/fw_config: Make fw_config_is_provisioned() always available ......................................................................
lib/fw_config: Make fw_config_is_provisioned() always available
Move fw_config_is_provisioned() implementation to header file and make it static inline.
Signed-off-by: Jakub Czapiga jacz@semihalf.com Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75835 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/include/fw_config.h M src/lib/fw_config.c 2 files changed, 10 insertions(+), 11 deletions(-)
Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve
diff --git a/src/include/fw_config.h b/src/include/fw_config.h index 9f5e4b8..1e1652e 100644 --- a/src/include/fw_config.h +++ b/src/include/fw_config.h @@ -49,6 +49,16 @@ */ uint64_t fw_config_get(void);
+/** + * fw_config_is_provisioned() - Determine if FW_CONFIG has been provisioned. + * Return %true if FW_CONFIG has been provisioned, %false otherwise. + */ +static inline bool fw_config_is_provisioned(void) +{ + return fw_config_get() != UNDEFINED_FW_CONFIG; +} + + #if CONFIG(FW_CONFIG)
/** @@ -77,12 +87,6 @@ void fw_config_for_each_found(void (*cb)(const struct fw_config *config, void *arg), void *arg);
/** - * fw_config_is_provisioned() - Determine if FW_CONFIG has been provisioned. - * Return %true if FW_CONFIG has been provisioned, %false otherwise. - */ -bool fw_config_is_provisioned(void); - -/** * fw_config_get_found() - Return a pointer to the fw_config struct for a given field. * @field_mask: A field mask from static.h, e.g., FW_CONFIG_FIELD_FEATURE_MASK * diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index e1fbe74..268be07 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -95,11 +95,6 @@ return false; }
-bool fw_config_is_provisioned(void) -{ - return fw_config_get() != UNDEFINED_FW_CONFIG; -} - bool fw_config_probe_dev(const struct device *dev, const struct fw_config **matching_probe) { const struct fw_config *probe;