Attention is currently required from: Hung-Te Lin, Jarried Lin, Xinxiong Xu, Yang Wu.
Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85858?usp=email )
Change subject: mb/google/rauru: Add alc5650 support ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85858/comment/1299591e_1494f339?usp... : PS2, Line 9: depthcharge the payload
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85858/comment/e66be4c3_3e0a1256?usp... : PS2, Line 21: i2s
Could you also send a separate patch and rename this to `configure_tas2563` ?
I'm fine with doing that in this patch, as it's only straightforward refactoring.
https://review.coreboot.org/c/coreboot/+/85858/comment/6af344a4_b4d3151e?usp... : PS2, Line 33: { Should we add `/* Switch to normal mode */` similar to the code above?
https://review.coreboot.org/c/coreboot/+/85858/comment/b83ccb03_19f27710?usp... : PS2, Line 34: write32p(AFE_SE_SECURE_CON1, 0x0); A blank line below.