Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86063?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/starlabs/starlite_adl: Correct USB Port comments ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: might as well fix the ACPI entries as well 😊
File src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/86063/comment/96d7b52d_9c7ed984?usp... : PS1, Line 75: Top ```suggestion register "desc" = ""Bottom USB Type-C"" ```
https://review.coreboot.org/c/coreboot/+/86063/comment/84d0257c_4c4d2d8e?usp... : PS1, Line 81: Top ```suggestion register "desc" = ""Bottom USB Type-C"" ```
https://review.coreboot.org/c/coreboot/+/86063/comment/3b1c6d58_16c89987?usp... : PS1, Line 87: Bottom ```suggestion register "desc" = ""Top USB Type-C"" ```
https://review.coreboot.org/c/coreboot/+/86063/comment/72d866e5_3bc32f00?usp... : PS1, Line 93: Bottom ```suggestion register "desc" = ""Top USB Type-C"" ```