Attention is currently required from: Jérémy Compostella, Subrata Banik.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81927?usp=email )
Change subject: [MTL-x64]src/intel/common: Add support for 32bit memcpy. ......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/81927/comment/aa20aa1b_01be5d99 : PS2, Line 76: static void memcpy2(void* addr, const void* data, size_t len) {
submit this as generic changes in the same file where we have memcpy implemented
ACK.
https://review.coreboot.org/c/coreboot/+/81927/comment/4000f611_ddbd30d8 : PS2, Line 103: memcpy2((void *)(ctx->mmio_base + SPIBAR_FDATA(0)), data, len);
ideally guard against X86_64 config and keep memcpy for 32-bit code.
ACK.