Change in coreboot[master]: mb/google/zork/vilboz: Enable P sensor

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: src:...

Frank Wu (Code Review)

21 Sep 2020 21 Sep '20

10:57 a.m.

Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

mb/google/zork/vilboz: Enable P sensor

BUG=b:161759253 BRANCH=firmware-zork-13434.B TEST=emerge-zork coreboot chromeos-bootimage

Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 --- M src/mainboard/google/zork/variants/vilboz/gpio.c M src/mainboard/google/zork/variants/vilboz/overridetree.cb 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45565/1

diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c index 12b303a..d4bcfa5 100644 --- a/src/mainboard/google/zork/variants/vilboz/gpio.c +++ b/src/mainboard/google/zork/variants/vilboz/gpio.c @@ -10,6 +10,8 @@ static const struct soc_amd_gpio bid_1_gpio_set_stage_ram[] = { /* TP */ PAD_NC(GPIO_32), + /* P sensor INT */ + PAD_GPI(GPIO_40, PULL_NONE), /* EN_DEV_BEEP_L */ PAD_GPO(GPIO_89, HIGH), /* USI_RESET */ diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index d415de5..932805f 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -136,5 +136,12 @@ register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end + chip drivers/i2c/generic + register "hid" = ""STH9324"" + register "name" = ""SEMTECH SX9324"" + register "desc" = ""SAR Proximity Sensor"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + device i2c 28 on end + end end end # chip soc/amd/picasso

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

Frank Wu (Code Review)

23 Sep 23 Sep

8:47 a.m.

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 1:

Hi Google,

Would you help review the CL or give us some suggestion? Thank you very much.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 23 Sep 2020 05:47:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:04 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable P sensor ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 14: PAD_GPI Shouldn't this be PAD_INT?

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324 What kernel driver is used for this? I don't see this HID in kernel v5.4

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 23 Sep 2020 06:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frank Wu (Code Review)

noon

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Aaron Durbin, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45565

to look at the new patch set (#2).

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

BUG=b:161759253 BRANCH=firmware-zork-13434.B TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45565/2

Frank Wu (Code Review)

12:15 p.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 14: PAD_GPI

...

Shouldn't this be PAD_INT?

Done

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324

...

What kernel driver is used for this? I don't see this HID in kernel v5. […]

According to https://partnerissuetracker.corp.google.com/issues/161759253#comment8 , there is no device driver for STH9324 in kernel v5.4 now. The kernel driver should be cherry-picked/upstreamed to kernel v5.4 later.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 23 Sep 2020 09:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Frank Wu (Code Review)

29 Sep 29 Sep

5:12 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2:

Hi Google,

Would you help review the CL or give us some suggestion? Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 29 Sep 2020 02:12:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:36 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... PS2, Line 10: bid_1_gpio_set_stage_ram Is P-sensor interrupt used only on board with version 1 or all future board versions as well? If it is used on all future board versions too, then you will have to add another table that will configure this interrupt line for future board versions and will be returned on line 39.

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324

...

According to https://partnerissuetracker.corp.google.com/issues/161759253#comment8 , […]

I think it would be good to get the driver in before landing this change. So that the ACPI information is correctly supplied here as per the driver expectations.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 29 Sep 2020 02:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Frank Wu (Code Review)

5:57 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... PS2, Line 10: bid_1_gpio_set_stage_ram

...

Is P-sensor interrupt used only on board with version 1 or all future board versions as well? If it […]

I will discuss that with our hardware team and update result later.

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324

...

I think it would be good to get the driver in before landing this change. […]

I appreciate the comment.

Here is the CL for kernel driver. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2... We are going to verify the p snesor function is workable or not. I will keep you posted. Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 29 Sep 2020 02:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

12 Oct 12 Oct

11:19 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 12 Oct 2020 08:19:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frank Wu (Code Review)

11:31 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2:

Here is the result for reference. https://partnerissuetracker.corp.google.com/issues/161759253#comment22

Would you help review? Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 12 Oct 2020 08:31:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

13 Oct 13 Oct

7:04 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 2: Code-Review+1

Oh, still need to confirm with HW for the gpio.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 13 Oct 2020 04:04:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frank Wu (Code Review)

14 Oct 14 Oct

10:16 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Aaron Durbin, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45565

to look at the new patch set (#3).

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

BUG=b:161759253 BRANCH=firmware-zork-13434.B TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45565/3

Frank Wu (Code Review)

11:45 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 3:

(1 comment)

Would you help review the CL based on result https://partnerissuetracker.corp.google.com/issues/161759253#comment23 ?

Thank you.

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... PS2, Line 10: bid_1_gpio_set_stage_ram

...

I will discuss that with our hardware team and update result later.

The schematic about p sensor will not be modified for board version 2+. Therefore, the gpio is configured in vilboz_gpio_set_stage_ram. I will create another issue to track and update the rest gpios between board version 1 and 2.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 14 Oct 2020 08:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Frank Wu (Code Review)

11:47 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324

...

I appreciate the comment. […]

The result: https://partnerissuetracker.corp.google.com/issues/161759253#comment23 and https://partnerissuetracker.corp.google.com/issues/161759253#comment22

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 14 Oct 2020 08:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Frank Wu (Code Review)

19 Oct 19 Oct

10:34 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 3:

Hi Google,

Would you help review the CL or give us some suggestion? Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 19 Oct 2020 07:34:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

6:08 p.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45565/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45565/3//COMMIT_MSG@11 PS3, Line 11: TEST=emerge-zork coreboot chromeos-bootimage Any logs in coreboot or Linux, that show that it’s enabled? Please paste those.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 19 Oct 2020 15:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frank Wu (Code Review)

20 Oct 20 Oct

9:09 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Aaron Durbin, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45565

to look at the new patch set (#4).

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

BUG=b:161759253 BRANCH=firmware-zork-13434.B TEST=emerge-zork coreboot chromeos-bootimage firmware log: _SB.I2C2.SEMTECH SX9324: SAR Proximity Sensor at I2C: 02:28 kernel log: INFO kernel: [ 11.238644] sx932x i2c-STH9324:00: initial compensation success

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45565/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frank Wu (Code Review)

9:11 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45565/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45565/3//COMMIT_MSG@11 PS3, Line 11: TEST=emerge-zork coreboot chromeos-bootimage

...

Any logs in coreboot or Linux, that show that it’s enabled? Please paste those.

The logs from firmware and kernel are updated to commit message for reference.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Oct 2020 06:11:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:47 p.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Oct 2020 13:47:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frank Wu (Code Review)

22 Oct 22 Oct

5:27 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4:

Hi Google,

Would you help to review the CL? Then we can have CPFE FW image to verify it. Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 22 Oct 2020 02:27:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kangheui Won (Code Review)

6:15 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 22 Oct 2020 03:15:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sam McNally (Code Review)

6:18 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 22 Oct 2020 03:18:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

6:45 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 22 Oct 2020 03:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Oct 26 Oct

8:45 a.m.

New subject: Change in coreboot[master]: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45565 )

Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................

mb/google/zork/vilboz: Enable SAR proximity sensor STH9324

Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45565 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Sam McNally sammc@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/gpio.c M src/mainboard/google/zork/variants/vilboz/overridetree.cb 2 files changed, 14 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve Sam McNally: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c index 91ed61a..6fba0e2 100644 --- a/src/mainboard/google/zork/variants/vilboz/gpio.c +++ b/src/mainboard/google/zork/variants/vilboz/gpio.c @@ -16,6 +16,11 @@ PAD_GPO(GPIO_140, HIGH), };

+static const struct soc_amd_gpio vilboz_gpio_set_stage_ram[] = { + /* P sensor INT */ + PAD_INT(GPIO_40, PULL_NONE, LEVEL_LOW, STATUS_DELIVERY), +}; + const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) { uint32_t board_version; @@ -33,6 +38,6 @@ return bid_1_gpio_set_stage_ram; }

- *size = 0; - return NULL; + *size = ARRAY_SIZE(vilboz_gpio_set_stage_ram); + return vilboz_gpio_set_stage_ram; } diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index a93beb5..a61c027 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -142,5 +142,12 @@ register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end + chip drivers/i2c/generic + register "hid" = ""STH9324"" + register "name" = ""SEMTECH SX9324"" + register "desc" = ""SAR Proximity Sensor"" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_40)" + device i2c 28 on end + end end end # chip soc/amd/picasso

-- To view, visit https://review.coreboot.org/c/coreboot/+/45565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889 Gerrit-Change-Number: 45565 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Kangheui Won khwon@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-MessageType: merged

1548

days inactive

1583

days old

coreboot-gerrit@coreboot.org

23 comments

7 participants

tags (0)

participants (7)

EricR Lai (Code Review)
Frank Wu (Code Review)
Furquan Shaikh (Code Review)
Kangheui Won (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Sam McNally (Code Review)