HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31038
Change subject: src/superio: Use FixedIO ......................................................................
src/superio: Use FixedIO
Change-Id: Iec28593b3cfd1a6061d30c4f7dec1326666b0734 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/acpi/pnp_kbc.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/smsc/mec1308/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl M src/superio/winbond/w83627hf/acpi/superio.asl M src/superio/winbond/w83667hg-a/ps2_controller.asl 10 files changed, 37 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31038/1
diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl index cbcfd55..7b98590 100644 --- a/src/superio/acpi/pnp_kbc.asl +++ b/src/superio/acpi/pnp_kbc.asl @@ -91,8 +91,8 @@ Name (_PRS, ResourceTemplate () { StartDependentFn (0,0) { - IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) - IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) + FixedIO(0x0060, 0x01) + FixedIO(0x0064, 0x01) IRQNoFlags () {1} } EndDependentFn() diff --git a/src/superio/ite/it8720f/acpi/superio.asl b/src/superio/ite/it8720f/acpi/superio.asl index 1e94655..b6dba7c 100644 --- a/src/superio/ite/it8720f/acpi/superio.asl +++ b/src/superio/ite/it8720f/acpi/superio.asl @@ -95,7 +95,7 @@ { /* Announce the used I/O ports to the OS */ Return (ResourceTemplate () { - IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) + FixedIO (SUPERIO_PNP_BASE, 0x02) }) }
diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index a8a0564..f94fd9a 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -161,13 +161,13 @@
Name (_CRS, ResourceTemplate () { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) + FixedIO (SIO_GPIO_IO0, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) })
Name (_PRS, ResourceTemplate () { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) + FixedIO (SIO_GPIO_IO0, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) } @@ -208,15 +208,15 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} })
Name (_PRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} }) } @@ -254,16 +254,16 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) + FixedIO (0x03F0, 0x06) + FixedIO (0x03F7, 0x01) IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} })
Name (_PRS, ResourceTemplate() { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) + FixedIO (0x03F0, 0x06) + FixedIO (0x03F7, 0x01) IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) diff --git a/src/superio/ite/it8783ef/acpi/superio.asl b/src/superio/ite/it8783ef/acpi/superio.asl index d7a320e..90b2991 100644 --- a/src/superio/ite/it8783ef/acpi/superio.asl +++ b/src/superio/ite/it8783ef/acpi/superio.asl @@ -97,7 +97,7 @@ { /* Announce the used i/o ports to the OS */ Return (ResourceTemplate () { - IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) + FixedIO (SUPERIO_PNP_BASE, 0x02) }) }
diff --git a/src/superio/nuvoton/nct6776/acpi/superio.asl b/src/superio/nuvoton/nct6776/acpi/superio.asl index abd5562..acfba5a 100644 --- a/src/superio/nuvoton/nct6776/acpi/superio.asl +++ b/src/superio/nuvoton/nct6776/acpi/superio.asl @@ -88,14 +88,14 @@ Offset (0x72), PNP_IRQ1, 8, /* Second IRQ */ Offset (0x74), - PNP_DMA0, 8, /* DRQ */ + PNP_DMA0, 8, /* DMA */ }
Method (_CRS) { /* Announce the used I/O ports to the OS */ Return (ResourceTemplate () { - IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) + FixedIO (SUPERIO_PNP_BASE, 0x02) }) }
diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index cc174f9..5fa5e42 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -199,15 +199,15 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} })
Name (_PRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} }) } @@ -246,12 +246,12 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) + FixedIO (SIO_SMBX_IO0, 0x34) })
Name (_PRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) + FixedIO (SIO_SMBX_IO0, 0x34) }) } #endif diff --git a/src/superio/smsc/sio1007/acpi/superio.asl b/src/superio/smsc/sio1007/acpi/superio.asl index a8a0564..f94fd9a 100644 --- a/src/superio/smsc/sio1007/acpi/superio.asl +++ b/src/superio/smsc/sio1007/acpi/superio.asl @@ -161,13 +161,13 @@
Name (_CRS, ResourceTemplate () { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) + FixedIO (SIO_GPIO_IO0, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) })
Name (_PRS, ResourceTemplate () { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) + FixedIO (SIO_GPIO_IO0, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) } @@ -208,15 +208,15 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} })
Name (_PRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQNoFlags () {1} }) } @@ -254,16 +254,16 @@
Name (_CRS, ResourceTemplate() { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) + FixedIO (0x03F0, 0x06) + FixedIO (0x03F7, 0x01) IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} })
Name (_PRS, ResourceTemplate() { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) + FixedIO (0x03F0, 0x06) + FixedIO (0x03F7, 0x01) IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) diff --git a/src/superio/winbond/w83627dhg/acpi/superio.asl b/src/superio/winbond/w83627dhg/acpi/superio.asl index 301ee94..70366d8 100644 --- a/src/superio/winbond/w83627dhg/acpi/superio.asl +++ b/src/superio/winbond/w83627dhg/acpi/superio.asl @@ -106,7 +106,7 @@ { /* Announce the used i/o ports to the OS */ Return (ResourceTemplate () { - IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) + FixedIO (SUPERIO_PNP_BASE, 0x02) }) }
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index ef4504c..3000b87 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -1134,8 +1134,8 @@ { StartDependentFn (0,0) { IRQNoFlags () {1} - IO (Decode16, 0x0060, 0x0060, 0x01, 0x01) - IO (Decode16, 0x0064, 0x0064, 0x01, 0x01) + FixedIO(0x0060, 0x01) + FixedIO(0x0064, 0x01) } EndDependentFn() }) diff --git a/src/superio/winbond/w83667hg-a/ps2_controller.asl b/src/superio/winbond/w83667hg-a/ps2_controller.asl index c3b5c75..55f9febe 100644 --- a/src/superio/winbond/w83667hg-a/ps2_controller.asl +++ b/src/superio/winbond/w83667hg-a/ps2_controller.asl @@ -38,8 +38,8 @@
Name(_CRS, ResourceTemplate() { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) + FixedIO (0x60, 0x01) + FixedIO (0x64, 0x01) IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 })
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31038
to look at the new patch set (#2).
Change subject: src/superio: Use FixedIO ......................................................................
src/superio: Use FixedIO
Change-Id: Iec28593b3cfd1a6061d30c4f7dec1326666b0734 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/acpi/pnp_kbc.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/smsc/mec1308/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl M src/superio/winbond/w83627hf/acpi/superio.asl M src/superio/winbond/w83667hg-a/ps2_controller.asl 10 files changed, 37 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31038/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31038 )
Change subject: src/superio: Use FixedIO ......................................................................
Patch Set 2:
FixedIO is restricted to 10-bit decode of address. So anywhere where parameter is not a literal value below 0x400 has to remain with IO(). I have doubts if it is worth changing any of these to FixedIO.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31038 )
Change subject: src/superio: Use FixedIO ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)