Change in coreboot[master]: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47984 )
Change subject: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG@15 PS6, Line 15: PAD_CFG_GPI_APIC_HIGH. There is no need to invert the signal. There is no need because the SoC supports active-low signals in the ITSS, AIUI. But you are using a macro that is named such that all signals going through the ITSS would be active high. Using this macro for other purposes makes the code incredibly hard to follow. Even with this note.
https://review.coreboot.org/c/coreboot/+/47984/6/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/gpio.c:
https://review.coreboot.org/c/coreboot/+/47984/6/src/mainboard/clevo/cml-u/v... PS6, Line 65: PAD_CFG_GPI_APIC_HIGH Given the double-inversion story, using _LOW here should work too, would be more consistent and much less confusing.
-
Nico Huber (Code Review)