Attention is currently required from: Felix Held, Martin L Roth, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 10:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83719/comment/1f4ad9bb_5aa162ee?usp... : PS8, Line 2: KunYi
Kun Yi?
'Kun Yi' or 'KunYi', what's your mean? KunYi is my first name
坤 -> Kun , 毅 -> Yi in hanyu pinyin system
https://review.coreboot.org/c/coreboot/+/83719/comment/039e82cf_f9881f5b?usp... : PS8, Line 10: Intel Alder Lake-N N100 processor : 8GB LPDDR5 memory : 64GB eMMC storage : SO-DIMM 260-pin connector for function expansion
Please format this as a list.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83719/comment/72d9a188_04b3f1c7?usp... : PS8, Line 21: Windows
Which version?
Acknowledged, Windows 11
File src/mainboard/lattepanda/mu/devicetree.cb:
PS8:
Missing SPDX license.
Acknowledged, I will update
https://review.coreboot.org/c/coreboot/+/83719/comment/c9d97ceb_7a37e1e4?usp... : PS8, Line 9: register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # USB3/2 Type A : register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # USB3/2 Type A : register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # USB2 Type A : register "usb2_ports[3]" = "USB2_PORT_EMPTY" : register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # USB2 Type A : register "usb2_ports[5]" = "USB2_PORT_EMPTY" : register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # M.2 E 2230 : : register "usb3_ports[0]" = "USB3_PORT_EMPTY" : register "usb3_ports[1]" = "USB3_PORT_EMPTY" : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A : register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A :
Use this format, and place it under `xhci`. […]
Acknowledged, check the new patch
File src/mainboard/lattepanda/mu/spd/mu_lp5_16gb.spd.hex:
PS8:
Generated how?
from vendor, I asked vendor 'DFRobot' give me memory configuration data
the Vendor provide SPDs information on https://discord.com/channels/910083833037205595/1227259796802109563/12663105...