Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85127?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 driver
......................................................................
Patch Set 13:
(2 comments)
File src/soc/mediatek/common/mt6363.c:
https://review.coreboot.org/c/coreboot/+/85127/comment/56d4f243_fde980af?usp... :
PS13, Line 29: write
`write8` (because there might be `write16` in the future)
https://review.coreboot.org/c/coreboot/+/85127/comment/6d974387_9ccdf7a9?usp... :
PS13, Line 29: u32
`u8` (because the write function calls `pmif_send_cmd` with `len = 1` in src/soc/mediatek/common/pmif.c)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85127?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf493b802522deba575d98c2ed69a93e94ce3d4e
Gerrit-Change-Number: 85127
Gerrit-PatchSet: 13
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 03 Dec 2024 14:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No