Attention is currently required from: Nico Huber, Furquan Shaikh, Werner Zeh, Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58524
to look at the new patch set (#2).
Change subject: soc/intel/apollolake: Fix BUG-message when checking for XDCI device ......................................................................
soc/intel/apollolake: Fix BUG-message when checking for XDCI device
The current check for XDCI enabled uses a static device path to an internal PCI device at a very late point in the boot flow. At this time the devicetree has been processed and disabled devices have been already removed. If this device (00:15.1, XDCI) is disabled in devicetree this will trigger the message 'BUG: check_xdci_enable requests hidden 00:15.1' in the log. This looks weird and is wrong since it is not a bug to disable this device when it is not needed.
To avoid this look up the devicetree by a tree walk instead of using a static value for the devicetree.
Change-Id: If193be724299c4017e7e10142fac8db9fac44383 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/soc/intel/apollolake/chip.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/58524/2