Change in coreboot[master]: mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value - coreboot-gerrit

10 Jan 2021


      Attention is currently required from: Furquan Shaikh, Martin Roth, Kangheui Won, Paul Menzel, Rob Barnes, EricR Lai.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49236 )
Change subject: mb/google/zork/var/vilboz: Fix FW_CONFIG_SHIFT_WWAN value
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49236/comment/a8abc53b_e5f116a7 
PS2, Line 9: Fix FW_CONFIG_SHIFT_WWAN value.
...
Why do we need to do this? Can you explain a bit more in the commit message?
Because it takes 2 bits for USE_FAN[27,28],
so FW_CONFIG_SHIFT_WWAN should be 29.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica6d04f9c48aa0800189283608bf57416ac75cf7
Gerrit-Change-Number: 49236
Gerrit-PatchSet: 2
Gerrit-Owner: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 02:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won khwon@chromium.org
Gerrit-MessageType: comment