Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68790 )
Change subject: device/mmio: add clr/setbitsXp macros
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS2:
Yeaaah, I stumbled upon that multiple times when using read*p tbh. […]
It was a side effect. The readXp/writeXp things were scattered around in native Intel code, and we decided to make them available everywhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18
Gerrit-Change-Number: 68790
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment