Attention is currently required from: Michał Kopeć, Michał Żygowski.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79080?usp=email )
Change subject: util: add smmstoretool for editing SMMSTORE
......................................................................
Patch Set 4:
(2 comments)
File util/smmstoretool/guids.c:
https://review.coreboot.org/c/coreboot/+/79080/comment/195dcc0b_8b9d2f6f :
PS4, Line 53: return strdup(known_guids->alias);
Typo? This should be `known_guid->alias`, otherwise the `coreboot` guid is always returned here
Definitely, thank you. Updated these functions before uploading and introduced bugs.
https://review.coreboot.org/c/coreboot/+/79080/comment/5c3260df_fe7e43af :
PS4, Line 73: *guid = known_guids->guid;
As above, I think this should be `known_guid->alias`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79080?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c1c06f1d0c39c13b5be76a3070f09b715aca6e0
Gerrit-Change-Number: 79080
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Mon, 20 Nov 2023 14:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment