Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK
There is currently no use for AP after CPU init and it looks like something goes wrong when halting APs right before booting the payload.
Change-Id: Id64425730a367d7a31716d26a1e99024e326baf2 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/ocp/tiogapass/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/48674/1
diff --git a/src/mainboard/ocp/tiogapass/Kconfig b/src/mainboard/ocp/tiogapass/Kconfig index 67c1fa9..4399401 100644 --- a/src/mainboard/ocp/tiogapass/Kconfig +++ b/src/mainboard/ocp/tiogapass/Kconfig @@ -10,7 +10,6 @@ select IPMI_KCS_ROMSTAGE select MAINBOARD_USES_FSP2_0 select OCP_DMI - select PARALLEL_MP_AP_WORK select SOC_INTEL_SKYLAKE_SP select SUPERIO_ASPEED_AST2400 select VPD
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
Patch Set 1: Code-Review+2
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
Patch Set 1:
This was added for change https://review.coreboot.org/c/coreboot/+/40308/53/src/drivers/ocp/dmi/smbios... To get the PPIN of the second socket I make use of this config, but if it's causing problems then I think it can be disabled unless we don't have any better way to do it.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
Patch Set 1: Code-Review-2
I'll investigate a bit further.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48674 )
Change subject: mb/ocp/tiogapass: Don't select PARALLEL_MP_AP_WORK ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Johnny Lin (Code Review)