Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 23 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/1
diff --git a/Makefile.inc b/Makefile.inc index 882673b..b5b81f0 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1133,42 +1133,8 @@ $(CBFSTOOL) $@.tmp add-int -i 2 -n etc/threads endif ifeq ($(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE),y) -ifneq ($(CONFIG_UPDATE_IMAGE),y) # never update the bootblock -ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) - @printf " UPDATE-FIT\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - -r COREBOOT -endif -ifeq ($(CONFIG_USE_CPU_MICROCODE_CBFS_BINS),y) - @printf " UPDATE-FIT\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - -r COREBOOT -endif +# Print final FIT table $(IFITTOOL) -f $@.tmp -D -r COREBOOT - -# Second FIT in TOP_SWAP bootblock -ifeq ($(CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK),y) -# INTEL_TOP_SWAP_FIT_ENTRY_FMAP_REG adds a region as first ucode into the seconds bootblock -ifneq ($(FIT_ENTRY),) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -A -n $(FIT_ENTRY) -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif -ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif -ifeq ($(CONFIG_USE_CPU_MICROCODE_CBFS_BINS),y) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif - $(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT - -endif - -endif # !CONFIG_UPDATE_IMAGE endif # CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE mv $@.tmp $@ @printf " CBFSLAYOUT $(subst $(obj)/,,$(@))\n\n" diff --git a/src/cpu/intel/fit/Makefile.inc b/src/cpu/intel/fit/Makefile.inc index 4b540ba..0d1ab60 100644 --- a/src/cpu/intel/fit/Makefile.inc +++ b/src/cpu/intel/fit/Makefile.inc @@ -1 +1,23 @@ bootblock-y += fit.S + +ifneq ($(CONFIG_UPDATE_IMAGE),y) # never update the bootblock +ifneq ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y) +INTERMEDIATE+=add_mcu_fit +add_mcu_fit: $(obj)/coreboot.pre $(IFITTOOL) + @printf " UPDATE-FIT Microcode\n" + $(IFITTOOL) -f $< -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -r COREBOOT + +# Second FIT in TOP_SWAP bootblock +ifeq ($(CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK),y) +INTERMEDIATE+=add_ts_mcu_fit +add_ts_mcu_fit: $(obj)/coreboot.pre $(IFITTOOL) + @printf " UPDATE-FIT Top Swap: Microcode\n" +ifneq ($(FIT_ENTRY),) + $(IFITTOOL) -f $< -A -n $(FIT_ENTRY) -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) $(TS_OPTIONS) -r COREBOOT +endif + $(IFITTOOL) -f $< -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) $(TS_OPTIONS) -r COREBOOT +endif # ($(CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK),y) +endif # ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y) +endif # ($(CONFIG_UPDATE_IMAGE),y) + +
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 1: Code-Review+1
Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46453
to look at the new patch set (#2).
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 21 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 5: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46453/8/src/cpu/intel/fit/Makefile.... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/8/src/cpu/intel/fit/Makefile.... PS8, Line 15: FIT_ENTRY Probably good to move the definition here too
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc@a1173 PS10, Line 1173: IFITTOOL This line was dropped
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile... PS10, Line 6: add_mcu_fit Do you need to mark this as phony?
Hello Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Jamie Ryu, Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46453
to look at the new patch set (#11).
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 30 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/11
Hello Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Jamie Ryu, Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46453
to look at the new patch set (#12).
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 30 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/12
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1075 PS12, Line 1075: endif Why move this? It's used right below in line 1088 and not specific to FIT.
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1185 PS12, Line 1185: $(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT The new comment suggests that this should have stayed?
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@1153 PS12, Line 1153: TS_OPTIONS := -j $(CONFIG_INTEL_TOP_SWAP_BOOTBLOCK_SIZE) This is redundant with the same line in the new file.
Does it even work inside a recipe?
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... PS12, Line 10: ifneq ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y) Maybe add an empty line below this and above the matching `endif`, to make it more visible that it encloses the rest of the file.
Hello Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Jamie Ryu, Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46453
to look at the new patch set (#13).
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 32 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/13
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1075 PS12, Line 1075: endif
Why move this? It's used right below in line 1088 and not specific to FIT.
Done
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1185 PS12, Line 1185: $(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT
The new comment suggests that this should have stayed?
Done
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@1153 PS12, Line 1153: TS_OPTIONS := -j $(CONFIG_INTEL_TOP_SWAP_BOOTBLOCK_SIZE)
This is redundant with the same line in the new file.
Does it even work inside a recipe?
Looks like I messed up here. It should have been "$(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT"
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... PS12, Line 10: ifneq ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y)
Maybe add an empty line below this and above the matching `endif`, to make it more visible that it encloses the rest of the file.
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc@a1173 PS10, Line 1173: IFITTOOL
This line was dropped
Done
https://review.coreboot.org/c/coreboot/+/46453/13/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/13/Makefile.inc@a1075 PS13, Line 1075: endif Now it's completely gone? :-/
https://review.coreboot.org/c/coreboot/+/46453/8/src/cpu/intel/fit/Makefile.... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/8/src/cpu/intel/fit/Makefile.... PS8, Line 15: FIT_ENTRY
Probably good to move the definition here too
Done
Hello Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Jamie Ryu, Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46453
to look at the new patch set (#14).
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 32 insertions(+), 35 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/46453/14
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46453/13/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/13/Makefile.inc@a1075 PS13, Line 1075: endif
Now it's completely gone? :-/
Fixed. thanks
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile... PS10, Line 6: add_mcu_fit
Do you need to mark this as phony?
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16: Code-Review+1
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16: Code-Review-2
Ugh, Asrock B85M Pro4 now doesn't have any microcode in FIT...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 16: Code-Review+2
Can't reproduce anymore
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Makefile.inc: Move adding mcu FIT entries
This can be done using in the INTERMEDIATE target in the proper place.
Change-Id: I28a7764205e0510be89c131058ec56861a479699 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/46453 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc M src/cpu/intel/fit/Makefile.inc 2 files changed, 32 insertions(+), 35 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/Makefile.inc b/Makefile.inc index 9273961..fafb9ec 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1121,8 +1121,6 @@ $(RMODTOOL) -i $(CONFIG_REFCODE_BLOB_FILE) -o $@ endif
-FIT_ENTRY=$(call strip_quotes, $(CONFIG_INTEL_TOP_SWAP_FIT_ENTRY_FMAP_REG)) - ifeq ($(CONFIG_HAVE_RAMSTAGE),y) RAMSTAGE=$(objcbfs)/ramstage.elf else @@ -1136,42 +1134,13 @@ dd if=/dev/zero bs=$(call _toint,$(CONFIG_ROM_SIZE)) count=1 2> /dev/null | tr '\000' '\377' > $@.tmp dd if=$(obj)/coreboot.pre of=$@.tmp bs=8192 conv=notrunc 2> /dev/null ifeq ($(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE),y) -ifneq ($(CONFIG_UPDATE_IMAGE),y) # never update the bootblock -ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) - @printf " UPDATE-FIT\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - -r COREBOOT -endif -ifeq ($(CONFIG_USE_CPU_MICROCODE_CBFS_BINS),y) - @printf " UPDATE-FIT\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - -r COREBOOT -endif +# Print final FIT table $(IFITTOOL) -f $@.tmp -D -r COREBOOT - -# Second FIT in TOP_SWAP bootblock +# Print final TS BOOTBLOCK FIT table ifeq ($(CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK),y) -# INTEL_TOP_SWAP_FIT_ENTRY_FMAP_REG adds a region as first ucode into the seconds bootblock -ifneq ($(FIT_ENTRY),) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -A -n $(FIT_ENTRY) -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif -ifeq ($(CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER),y) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif -ifeq ($(CONFIG_USE_CPU_MICROCODE_CBFS_BINS),y) - @printf " UPDATE-FIT2\n" - $(IFITTOOL) -f $@.tmp -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) \ - $(TS_OPTIONS) -r COREBOOT -endif + @printf " TOP SWAP FIT table\n" $(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT - -endif - -endif # !CONFIG_UPDATE_IMAGE +endif # CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK endif # CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE mv $@.tmp $@ @printf " CBFSLAYOUT $(subst $(obj)/,,$(@))\n\n" diff --git a/src/cpu/intel/fit/Makefile.inc b/src/cpu/intel/fit/Makefile.inc index 4b540ba..9866684 100644 --- a/src/cpu/intel/fit/Makefile.inc +++ b/src/cpu/intel/fit/Makefile.inc @@ -1 +1,29 @@ bootblock-y += fit.S + +FIT_ENTRY=$(call strip_quotes, $(CONFIG_INTEL_TOP_SWAP_FIT_ENTRY_FMAP_REG)) + +ifneq ($(CONFIG_UPDATE_IMAGE),y) # never update the bootblock + +ifneq ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y) + +INTERMEDIATE+=add_mcu_fit +add_mcu_fit: $(obj)/coreboot.pre $(IFITTOOL) + @printf " UPDATE-FIT Microcode\n" + $(IFITTOOL) -f $< -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -r COREBOOT + +# Second FIT in TOP_SWAP bootblock +ifeq ($(CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK),y) + +INTERMEDIATE+=add_ts_mcu_fit +add_ts_mcu_fit: $(obj)/coreboot.pre $(IFITTOOL) + @printf " UPDATE-FIT Top Swap: Microcode\n" +ifneq ($(FIT_ENTRY),) + $(IFITTOOL) -f $< -A -n $(FIT_ENTRY) -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) $(TS_OPTIONS) -r COREBOOT +endif # FIT_ENTRY + $(IFITTOOL) -f $< -a -n cpu_microcode_blob.bin -t 1 -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) $(TS_OPTIONS) -r COREBOOT + +endif # CONFIG_INTEL_ADD_TOP_SWAP_BOOTBLOCK + +endif # CONFIG_CPU_MICROCODE_CBFS_NONE + +endif # CONFIG_UPDATE_IMAGE