Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50254 )
Change subject: vc/intel/fsp/fsp2_0/alderlake: Add required macros into MemInfoHob.h
......................................................................
Patch Set 1:
(2 comments)
File src/vendorcode/intel/fsp/fsp2_0/alderlake/MemInfoHob.h:
https://review.coreboot.org/c/coreboot/+/50254/comment/fa1f5a27_4a4130a4
PS1, Line 27: MAX_TRACE_CACHE_TYPE
MAX_TRACE_CACHE_TYPE already defined here?
https://review.coreboot.org/c/coreboot/+/50254/comment/2aa7e0de_44b77a6a
PS1, Line 156: MAX_TRACE_REGION
Looks like nothing currently uses this definition
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50254
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18370edca481bac5fdd483680cd7b05b216d10fc
Gerrit-Change-Number: 50254
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Feb 2021 09:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment