Attention is currently required from: Ravi kumar, Sudheer Amrabadi. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58372 )
Change subject: soc/common/qualcomm: Initialize AOP regions ......................................................................
Patch Set 3:
(1 comment)
File src/soc/qualcomm/common/mmu.c:
https://review.coreboot.org/c/coreboot/+/58372/comment/a7609bbc_40fc3f17 PS3, Line 22: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), : CACHED_RAM); : mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), : CACHED_RAM); _aop_code_ram and _aop_data_ram are defined in the following patch, so this CL will not compile:
aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:22: undefined reference to `_aop_code_ram' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:22: undefined reference to `_aop_code_ram_size' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:22: undefined reference to `_aop_code_ram' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:24: undefined reference to `_aop_data_ram_size' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:24: undefined reference to `_aop_data_ram' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:24: undefined reference to `_aop_data_ram_size' aarch64-elf-ld.bfd: /home/coreboot/node-root/workspace/coreboot-gerrit/src/soc/qualcomm/common/mmu.c:24: undefined reference to `_aop_data_ram'
-
Shelley Chen (Code Review)