Hello Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19828
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Implement GPIO ACPI AML generating functions ......................................................................
soc/intel/skylake: Implement GPIO ACPI AML generating functions
Implement GPIO ACPI AML generating functions that can be called by coreboot drivers to generate GPIO manipulation code in AML. Following API functions are implemented:
1. acpigen_soc_read_rx_gpio 2. acpigen_soc_get_tx_gpio 3. acpigen_soc_set_tx_gpio 4. acpigen_soc_clear_tx_gpio
In addition to the API functions above, helper functions are added to gpio.asl to set/clear/get Tx value of GPIO.
BUG=b:62028489
Change-Id: I77e5d0decd8929a922d06b02312378f092551667 Signed-off-by: Furquan Shaikh furquan@chromium.org --- M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/acpi/gpio.asl 2 files changed, 82 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/19828/2